-
Notifications
You must be signed in to change notification settings - Fork 107
add product diags to 'working with support' #1921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 Preview links for changed docs: 🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. A few recommendations.
Co-authored-by: Brandon Morelli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🏎️
Thanks Stef!
Co-authored-by: David Kilfoyle <[email protected]>
Co-authored-by: shainaraskas <[email protected]> Co-authored-by: David Kilfoyle <[email protected]>
👋 May I have another review/guess on how to cross-reference the Logstash logging doc? 🙏 ![]() |
I added a commit that should hopefully fix that error. 🤞 I'll keep an eye on it. |
There's one remaining build error but it's not related to the changes here (I'm also seeing it in my ILM PR):
Given that it's after hours I'd prefer not to raise alarm bells right now, but I'll deal with it on Monday if it's not already sorted out when I come back online. |
Co-authored-by: David Kilfoyle <[email protected]>
👋 howdy, team + @kilfoyle ! Low-level pass at #1725 🙏