Skip to content

add product diags to 'working with support' #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 28, 2025

Conversation

stefnestor
Copy link
Contributor

@stefnestor stefnestor commented Jun 25, 2025

👋 howdy, team + @kilfoyle ! Low-level pass at #1725 🙏

@stefnestor stefnestor requested a review from a team as a code owner June 25, 2025 22:57
Copy link

github-actions bot commented Jun 25, 2025

🔍 Preview links for changed docs:

🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes.

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. A few recommendations.

Co-authored-by: Brandon Morelli <[email protected]>
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🏎️
Thanks Stef!

Co-authored-by: David Kilfoyle <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: David Kilfoyle <[email protected]>
@stefnestor
Copy link
Contributor Author

👋 May I have another review/guess on how to cross-reference the Logstash logging doc? 🙏

image

@kilfoyle
Copy link
Contributor

👋 May I have another review/guess on how to cross-reference the Logstash logging doc? 🙏

I added a commit that should hopefully fix that error. 🤞 I'll keep an eye on it.

@kilfoyle
Copy link
Contributor

kilfoyle commented Jun 27, 2025

There's one remaining build error but it's not related to the changes here (I'm also seeing it in my ILM PR):

Error: 'elastic/elasticsearch' links to unknown file: 'manage-data/data-store/data-streams/failure-store.md' in the 'docs-content' cross link index: https://elastic-docs-link-index.s3.us-east-2.amazonaws.com/elastic/docs-content/main/links.json
NOTE: https://elastic-docs-link-index.s3.us-east-2.amazonaws.com/elastic/docs-content/main/links.json

Given that it's after hours I'd prefer not to raise alarm bells right now, but I'll deal with it on Monday if it's not already sorted out when I come back online.

@kilfoyle kilfoyle self-requested a review June 27, 2025 21:53
@stefnestor stefnestor merged commit e240749 into elastic:main Jun 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants